Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Bug fix for the input of same axes of the swapaxes operator #16513

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

xiezhq-hermann
Copy link
Contributor

Description

Bug fix for the input of same axes of the swapaxes operator

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

@reminisce It should be a simple and clean fix

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiezhq-hermann
Copy link
Contributor Author

xiezhq-hermann commented Oct 17, 2019

Thanks for your contribution!
Could you please add a testcase in

https://github.com/apache/incubator-mxnet/blob/c2bbde75c36be2fef4a5e6d941cc01f5aabd9fd2/tests/python/unittest/test_operator.py#L701

Thank you!

Will do soon

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM. Thank you!

@reminisce reminisce merged commit 77e9898 into apache:master Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants